<html>
<head><meta charset="utf-8"><title>expected timeline for reviews? · t-compiler/help · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/index.html">t-compiler/help</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/expected.20timeline.20for.20reviews.3F.html">expected timeline for reviews?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="200283536"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/expected%20timeline%20for%20reviews%3F/near/200283536" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dirkjan Ochtman <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/expected.20timeline.20for.20reviews.3F.html#200283536">(Jun 09 2020 at 20:11)</a>:</h4>
<p>I made a small std PR (<a href="https://github.com/rust-lang/rust/issues/72994">#72994</a>) 6 days ago and haven't gotten any response</p>



<a name="200283542"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/expected%20timeline%20for%20reviews%3F/near/200283542" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dirkjan Ochtman <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/expected.20timeline.20for.20reviews.3F.html#200283542">(Jun 09 2020 at 20:11)</a>:</h4>
<p>should I ask for a new reviewer? if so, how?</p>



<a name="200284658"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/expected%20timeline%20for%20reviews%3F/near/200284658" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/expected.20timeline.20for.20reviews.3F.html#200284658">(Jun 09 2020 at 20:20)</a>:</h4>
<p>you can use <code>r? @reviewername</code> to ask for a different reviewer. If you don't know who to ask, posting here is totally fine. Often the triage team gets to PRs after 7 days of no activity, but feel free to act after less than that.</p>



<a name="200285189"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/expected%20timeline%20for%20reviews%3F/near/200285189" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dirkjan Ochtman <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/expected.20timeline.20for.20reviews.3F.html#200285189">(Jun 09 2020 at 20:25)</a>:</h4>
<p>ahh, would have waited for the triage team if I'd known about that</p>



<a name="200285297"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/expected%20timeline%20for%20reviews%3F/near/200285297" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dirkjan Ochtman <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/expected.20timeline.20for.20reviews.3F.html#200285297">(Jun 09 2020 at 20:26)</a>:</h4>
<p>thanks for the response -- where should tests go for this stuff?</p>



<a name="200285550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/expected%20timeline%20for%20reviews%3F/near/200285550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/expected.20timeline.20for.20reviews.3F.html#200285550">(Jun 09 2020 at 20:28)</a>:</h4>
<p>I'm pretty sure that libraries get tested inside the crates, in <code>#[cfg(test)]</code> modules, just like a regular library crate</p>



<a name="200285835"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/expected%20timeline%20for%20reviews%3F/near/200285835" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dirkjan Ochtman <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/expected.20timeline.20for.20reviews.3F.html#200285835">(Jun 09 2020 at 20:30)</a>:</h4>
<p>I don't see <code>task</code> or <code>Poll</code> in <a href="https://github.com/rust-lang/rust/tree/f981b13921f5504e8b71c70e973953d00ad0ba48/src/libcore/tests">https://github.com/rust-lang/rust/tree/f981b13921f5504e8b71c70e973953d00ad0ba48/src/libcore/tests</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>